Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Draft #1

Merged
merged 23 commits into from
Sep 12, 2023
Merged

Initial Draft #1

merged 23 commits into from
Sep 12, 2023

Conversation

expede
Copy link
Member

@expede expede commented Sep 11, 2023 •
edited
Loading

@expede expede marked this pull request as ready for review September 11, 2023 23:02
@expede expede changed the title Update README Initial Draft Sep 11, 2023
zeeshanlakhani
zeeshanlakhani reviewed Sep 12, 2023
View reviewed changes
Copy link

@zeeshanlakhani zeeshanlakhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@expede +1 for the appendix removal (was going to mention something in this vain). Made some suggestions/comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
zeeshanlakhani
zeeshanlakhani reviewed Sep 12, 2023
View reviewed changes
Copy link

@zeeshanlakhani zeeshanlakhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor ones here.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@expede expede added this pull request to the merge queue Sep 12, 2023
@expede expede removed this pull request from the merge queue due to a manual request Sep 12, 2023
@expede expede added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit 9ade6e0 Sep 12, 2023
2 checks passed
@expede expede deleted the initial branch September 12, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeshanlakhani zeeshanlakhani zeeshanlakhani approved these changes

@bmann bmann Awaiting requested review from bmann

Assignees

@zeeshanlakhani zeeshanlakhani

@expede expede

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@expede @zeeshanlakhani